[ 
https://issues.apache.org/jira/browse/METRON-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479562#comment-16479562
 ] 

ASF GitHub Bot commented on METRON-1548:
----------------------------------------

Github user merrimanr commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1010#discussion_r189066511
  
    --- Diff: 
metron-interface/metron-alerts/src/app/service/elasticsearch-localstorage-impl.ts
 ---
    @@ -47,6 +51,18 @@ export class ElasticSearchLocalstorageImpl extends 
DataSource {
         new ColumnMetadata('alert_status', 'string')
       ];
     
    +  getSourceTypeFromLocalstorage() {
    +    let sourceType: string;
    +    if (localStorage['metron-alerts-saved-search']) {
    +      let columnHeaders = 
JSON.parse(localStorage['metron-alerts-saved-search']);
    +      sourceType = columnHeaders[0]['tableColumns'].filter(colName => 
colName.name === 'source.type');
    +      if (sourceType && !this.defaultColumnMetadata['source.type']) {
    +        this.defaultColumnMetadata = 
this.defaultColumnMetadata.filter(colName => colName.name !== 'source:type');
    --- End diff --
    
    Same as https://github.com/apache/metron/pull/1010/files#r189060226


> Alerts UI: Remove hardcoded source:type and other fields that may vary
> ----------------------------------------------------------------------
>
>                 Key: METRON-1548
>                 URL: https://issues.apache.org/jira/browse/METRON-1548
>             Project: Metron
>          Issue Type: Sub-task
>            Reporter: Justin Leet
>            Priority: Major
>
> In Solr, we use source.type instead of source:type (which was originally due 
> to ES limitations, we'd prefer it to be common across both). However, it's 
> hardcoded in the alerts UI to be source:type, so nothing in the UI has a 
> source type and it breaks other things like metaalerts (which rely on source 
> type for being able to pull the data together).
> Any other configs / queries that would cause similar problems should be 
> updated appropriately.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to