[ 
https://issues.apache.org/jira/browse/METRON-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480513#comment-16480513
 ] 

ASF GitHub Bot commented on METRON-1548:
----------------------------------------

Github user justinleet commented on the issue:

    https://github.com/apache/metron/pull/1010
  
    @merrimanr After thinking about this a bit, is that actually a serious 
problem?  This setting is likely to only be done on initial install (e.g. when 
selecting Solr or ES).  Switching midlife is unlikely to be a problem for the 
vast majority of users.  Most users should never see the problem of it being 
switched because they'd never see `source:type` instead of `source.type` or 
vice versa, because you'd have to reindex all your old data into the new format 
anyway.  We'd need to improve documentation in the Solr feature branch to 
ensure that users initially set it up appropriately.
    
    Another way of going about this might be to have the app itself get config 
updates on the fly similar to how our topologies do, given that this particular 
one is from ZK.  At that point, you could do the mapping from old source type 
to new source type and update the storage appropriately.  I'm sure there's way 
more to it than just doing that though (when do you update UI for users, what 
are the potential snags in updating that when users are querying, etc.).


> Alerts UI: Remove hardcoded source:type and other fields that may vary
> ----------------------------------------------------------------------
>
>                 Key: METRON-1548
>                 URL: https://issues.apache.org/jira/browse/METRON-1548
>             Project: Metron
>          Issue Type: Sub-task
>            Reporter: Justin Leet
>            Priority: Major
>
> In Solr, we use source.type instead of source:type (which was originally due 
> to ES limitations, we'd prefer it to be common across both). However, it's 
> hardcoded in the alerts UI to be source:type, so nothing in the UI has a 
> source type and it breaks other things like metaalerts (which rely on source 
> type for being able to pull the data together).
> Any other configs / queries that would cause similar problems should be 
> updated appropriately.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to