[
https://issues.apache.org/jira/browse/METRON-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656583#comment-16656583
]
ASF GitHub Bot commented on METRON-1830:
----------------------------------------
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1240#discussion_r226576832
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alert-details/alert-details.component.ts
---
@@ -249,8 +249,8 @@ export class AlertDetailsComponent implements OnInit {
commentText += ' \'' +
this.alertCommentsWrapper[index].alertComment.comment + '\'';
}
-
this.metronDialogBox.showConfirmationMessage(commentText).subscribe(response =>
{
- if (response) {
+ let confirmedSubscription =
this.dialogService.confirm(commentText).subscribe(r => {
--- End diff --
Could we use const here instead of let?
It might be better to move the logic inside this subscription to a function
like in saved-serches.component.ts #67 or in table-view.component.ts #428
> Re-implement Alerts dialog box without jQuery
> ---------------------------------------------
>
> Key: METRON-1830
> URL: https://issues.apache.org/jira/browse/METRON-1830
> Project: Metron
> Issue Type: Bug
> Reporter: Shane Ardell
> Assignee: Shane Ardell
> Priority: Minor
>
> Currently, the dialog box class in both UIs directly manipulates the DOM with
> jQuery. This is problematic when using a framework like Angular because it
> causes a disconnect with how Angular handles and tracks DOM changes. We also
> don't take advantage of Angular's rendering engine.
> The dialog box can and should be implemented as a component and a singleton
> service (since we would never want to launch more than one modal at a time).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
