[
https://issues.apache.org/jira/browse/METRON-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656584#comment-16656584
]
ASF GitHub Bot commented on METRON-1830:
----------------------------------------
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1240#discussion_r226589395
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alerts-list/table-view/table-view.component.ts
---
@@ -72,15 +72,15 @@ export class TableViewComponent implements OnInit,
OnChanges, OnDestroy {
@Output() onSelectedAlertsChange = new EventEmitter< Alert[]>();
constructor(searchService: SearchService,
- metronDialogBox: MetronDialogBox,
updateService: UpdateService,
metaAlertService: MetaAlertService,
- globalConfigService: GlobalConfigService) {
+ globalConfigService: GlobalConfigService,
+ dialogService: DialogService) {
this.searchService = searchService;
- this.metronDialogBox = metronDialogBox;
this.updateService = updateService;
this.metaAlertService = metaAlertService;
this.globalConfigService = globalConfigService;
+ this.dialogService = dialogService;
--- End diff --
In other places, you haven't assigning injected dialogService to a field
but relying on Angular automagic. I see you tried to stay consistent with the
original constructor impl, but might worth considering to building up a
consistency on an application level.
> Re-implement Alerts dialog box without jQuery
> ---------------------------------------------
>
> Key: METRON-1830
> URL: https://issues.apache.org/jira/browse/METRON-1830
> Project: Metron
> Issue Type: Bug
> Reporter: Shane Ardell
> Assignee: Shane Ardell
> Priority: Minor
>
> Currently, the dialog box class in both UIs directly manipulates the DOM with
> jQuery. This is problematic when using a framework like Angular because it
> causes a disconnect with how Angular handles and tracks DOM changes. We also
> don't take advantage of Angular's rendering engine.
> The dialog box can and should be implemented as a component and a singleton
> service (since we would never want to launch more than one modal at a time).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
