[
https://issues.apache.org/jira/browse/METRON-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656587#comment-16656587
]
ASF GitHub Bot commented on METRON-1830:
----------------------------------------
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1240#discussion_r226597922
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alerts-list/tree-view/tree-view.component.ts
---
@@ -421,10 +423,13 @@ export class TreeViewComponent extends
TableViewComponent implements OnInit, OnC
if (this.canCreateMetaAlert(group.total)) {
let confirmationMsg = 'Do you wish to create a meta alert with ' +
(group.total === 1 ? ' alert' : group.total +
' selected alerts') + '?';
-
this.metronDialogBox.showConfirmationMessage(confirmationMsg).subscribe((response)
=> {
- if (response) {
+ let confirmedSubscription =
this.dialogService.confirm(confirmationMsg).subscribe(r => {
+ if (r === 'Confirmed') {
--- End diff --
I suggest to use (r === ConfirmationType.Confirmed) instead of the string
literal.
> Re-implement Alerts dialog box without jQuery
> ---------------------------------------------
>
> Key: METRON-1830
> URL: https://issues.apache.org/jira/browse/METRON-1830
> Project: Metron
> Issue Type: Bug
> Reporter: Shane Ardell
> Assignee: Shane Ardell
> Priority: Minor
>
> Currently, the dialog box class in both UIs directly manipulates the DOM with
> jQuery. This is problematic when using a framework like Angular because it
> causes a disconnect with how Angular handles and tracks DOM changes. We also
> don't take advantage of Angular's rendering engine.
> The dialog box can and should be implemented as a component and a singleton
> service (since we would never want to launch more than one modal at a time).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
