[
https://issues.apache.org/jira/browse/METRON-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662285#comment-16662285
]
ASF GitHub Bot commented on METRON-1830:
----------------------------------------
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1240
@tiborm In regard to the 'Initial' state check, I was able to do what you
suggested but only after switching from a BehaviorSubject to a Subject. I did
this because Subjects do not return the current value on Subscription. It only
triggers with the .next() call and returns the value you pass there. That was a
really great suggestion on your part and made me realize I was using the wrong
tool for the job.
I also made changes based on the rest of your feedback, but they were
straightforward and do not need further explanation here. Thanks for taking the
time to review my PR!
> Re-implement Alerts dialog box without jQuery
> ---------------------------------------------
>
> Key: METRON-1830
> URL: https://issues.apache.org/jira/browse/METRON-1830
> Project: Metron
> Issue Type: Bug
> Reporter: Shane Ardell
> Assignee: Shane Ardell
> Priority: Minor
>
> Currently, the dialog box class in both UIs directly manipulates the DOM with
> jQuery. This is problematic when using a framework like Angular because it
> causes a disconnect with how Angular handles and tracks DOM changes. We also
> don't take advantage of Angular's rendering engine.
> The dialog box can and should be implemented as a component and a singleton
> service (since we would never want to launch more than one modal at a time).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
