justinleet commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#discussion_r346614654
########## File path: dependencies_with_url.csv ########## @@ -52,6 +52,7 @@ javax.xml.stream:stax-api:jar:1.0-2:compile,COMMON DEVELOPMENT AND DISTRIBUTION jline:jline:jar:0.9.94:compile,BSD,http://jline.sourceforge.net junit:junit:jar:4.12:compile,Eclipse Public License 1.0,http://junit.org junit:junit:jar:4.4:compile,Common Public License Version 1.0,http://junit.org +junit:junit:jar:4.10:compile,Common Public License Version 1.0,http://junit.org Review comment: I'll double check these. This might be able to be cleaned up, but I know in at least one case (json-simple), we're pulling tests in because they're compile in the transitive dependencies. https://jira.apache.org/jira/browse/METRON-2311 In terms of JUnit 4 used in the project, it should only be the `@Rule` for temporary folders. Anything else is leftover and should be dumped. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
