justinleet commented on a change in pull request #1554: METRON-2307: Migrate to
JUnit5
URL: https://github.com/apache/metron/pull/1554#discussion_r346623167
##########
File path: metron-analytics/metron-profiler-common/pom.xml
##########
@@ -79,8 +79,26 @@
</dependency>
<dependency>
<groupId>org.mockito</groupId>
- <artifactId>mockito-all</artifactId>
- <version>${global_mockito_version}</version>
+ <artifactId>mockito-core</artifactId>
+ <scope>test</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
Review comment:
Probably. I thought about doing it, and just didn't because I originally
intended to go more module by module. Then I got really sick of find/replace
module by module.
Particularly now that #1557 is in, it's probably safer to do this, but I'm a
bit hesitant to do it here just because I'm slightly worried we'd see more of
those issues and I mostly got lucky debugging that one.
It might be easier/cleaner to do this as a follow-on or some more general
maven cleanup?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
