justinleet commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#discussion_r346621880
########## File path: dependencies_with_url.csv ########## @@ -52,6 +52,7 @@ javax.xml.stream:stax-api:jar:1.0-2:compile,COMMON DEVELOPMENT AND DISTRIBUTION jline:jline:jar:0.9.94:compile,BSD,http://jline.sourceforge.net junit:junit:jar:4.12:compile,Eclipse Public License 1.0,http://junit.org junit:junit:jar:4.4:compile,Common Public License Version 1.0,http://junit.org +junit:junit:jar:4.10:compile,Common Public License Version 1.0,http://junit.org Review comment: `json-simple` does pull in 4.10. I assume that was just getting hidden by a different version getting pulled in from who knows where. 4.12 is pulled in by the migration support for `@Rule`, so it's junit5 itself pulling it in (for now). I did dump 4.4 though ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
