justinleet commented on a change in pull request #1554: METRON-2307: Migrate to
JUnit5
URL: https://github.com/apache/metron/pull/1554#discussion_r346615032
##########
File path:
metron-analytics/metron-maas-service/src/test/java/org/apache/metron/maas/service/MaasIntegrationTest.java
##########
@@ -234,13 +238,13 @@ public void run() {
}
Thread.sleep(2000);
}
- Assert.assertTrue(passed);
+ assertTrue(passed);
}
{
List<ModelEndpoint> endpoints = discoverer.getEndpoints(new
Model("dummy", "1.0"));
- Assert.assertNotNull(endpoints);
- Assert.assertEquals(1, endpoints.size());
+ assertNotNull(endpoints);
Review comment:
Yep, they should be. I didn't really set out to do it, but it was annoying
when converting those over so I just needed to pick one and stick with it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
