justinleet commented on a change in pull request #1554: METRON-2307: Migrate to
JUnit5
URL: https://github.com/apache/metron/pull/1554#discussion_r347037284
##########
File path:
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/config/KnoxSSOAuthenticationFilterTest.java
##########
@@ -100,19 +75,18 @@ public void doFilterShouldProperlySetAuthentication()
throws Exception {
ServletResponse response = mock(ServletResponse.class);
FilterChain chain = mock(FilterChain.class);
SignedJWT signedJWT = mock(SignedJWT.class);
- mockStatic(SignedJWT.class);
JWTClaimsSet jwtClaimsSet = new
JWTClaimsSet.Builder().subject("userName").build();
Authentication authentication = mock(Authentication.class);
SecurityContext securityContext = mock(SecurityContext.class);
- mockStatic(SecurityContextHolder.class);
when(request.getHeader("Authorization")).thenReturn(null);
doReturn("serializedJWT").when(knoxSSOAuthenticationFilter).getJWTFromCookie(request);
- when(SignedJWT.parse("serializedJWT")).thenReturn(signedJWT);
+// when(SignedJWT.parse("serializedJWT")).thenReturn(signedJWT);
Review comment:
Good call, dropped.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
