justinleet commented on a change in pull request #1554: METRON-2307: Migrate to
JUnit5
URL: https://github.com/apache/metron/pull/1554#discussion_r346844058
##########
File path: metron-stellar/stellar-common/pom.xml
##########
@@ -230,11 +230,29 @@
<version>${global_httpclient_version}</version>
</dependency>
<dependency>
- <!-- junit dependency added with default scope to allow inclusion
of StellarProcessorUtils in main jar.
- It is excluded from the uber-jar. -->
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>${global_junit_version}</version>
+ <groupId>org.hamcrest</groupId>
+ <artifactId>hamcrest-core</artifactId>
+ <version>${global_hamcrest_version}</version>
+ <scope>test</scope>
+ </dependency>
+ <!-- junit dependency added with default scope to allow inclusion of
StellarProcessorUtils in main jar.
+ It is excluded from the uber-jar. -->
+ <dependency>
Review comment:
While digging around for all the JUnit that makes its way into our uber
jars, I tried just doing the checks and throwing `AssertionError` and it seems
to work just fine.
https://github.com/justinleet/metron/blob/junit5_metron-2310/metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/StellarProcessorUtils.java
Should be easy enough to port it back to master, and possibly clean it up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
