mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to
JUnit5
URL: https://github.com/apache/metron/pull/1554#discussion_r348122344
##########
File path:
metron-platform/metron-elasticsearch/metron-elasticsearch-common/src/test/java/org/apache/metron/elasticsearch/writer/ElasticsearchWriterTest.java
##########
@@ -260,9 +240,9 @@ public void shouldWriteManySuccessfullyWithSetDocumentId()
{
when(writerConfiguration.isSetDocumentId("bro")).thenReturn(true);
when(writerConfiguration.getFieldNameConverter("bro")).thenReturn("NOOP");
- mockStatic(ElasticsearchUtils.class);
- when(ElasticsearchUtils.getIndexFormat(globals())).thenReturn(new
SimpleDateFormat());
- when(ElasticsearchUtils.getIndexName(eq("bro"), any(),
eq(writerConfiguration))).thenReturn("bro_index");
+// mockStatic(ElasticsearchUtils.class);
Review comment:
Missed commented out code. How is this not needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
