mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to
JUnit5
URL: https://github.com/apache/metron/pull/1554#discussion_r348610276
##########
File path:
metron-platform/metron-pcap-backend/src/test/java/org/apache/metron/pcap/integration/PcapTopologyIntegrationTest.java
##########
@@ -220,13 +208,13 @@ public static void setupTopology(Function<Properties,
Void> updatePropertiesCall
clearOutDirs(inputDir, interimResultDir, outputDir);
File baseDir = new File(new File(targetDir), BASE_DIR);
- //Assert.assertEquals(0, numFiles(outDir));
- Assert.assertNotNull(topologiesDir);
- Assert.assertNotNull(targetDir);
+ //assertEquals(0, numFiles(outDir));
Review comment:
I know it was previously commented out, but should we keep this assertion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
