mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to
JUnit5
URL: https://github.com/apache/metron/pull/1554#discussion_r348193833
##########
File path:
metron-platform/metron-management/src/test/java/org/apache/metron/management/FileSystemFunctionsTest.java
##########
@@ -101,75 +114,74 @@ public void setup() throws IOException {
rm.initialize(null);
}
- @AfterClass
- public static void teardown() {
- {
- hdfsCluster.shutdown();
- FileUtil.fullyDelete(hdfsBaseDir);
- }
- {
- new File(localPrefix).delete();
- }
- }
-
- @Test
- public void testHappyPath() {
+ @ParameterizedTest
+ @MethodSource("types")
+ public void testHappyPath(FileSystemFunctions.FS_TYPE type) {
+ setupFsTypeAndFunctions(type);
Review comment:
What's the reason for duplicating this in each test instead of keeping it in
```@BeforeEach
public void setup() throws IOException {
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
