mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to
JUnit5
URL: https://github.com/apache/metron/pull/1554#discussion_r348189222
##########
File path:
metron-platform/metron-indexing/metron-indexing-common/src/test/java/org/apache/metron/indexing/dao/metaalert/MetaAlertIntegrationTest.java
##########
@@ -998,18 +977,18 @@ public void shouldThrowExceptionIfPatchAlertField()
throws Exception {
String alertPatch = alertPatchRequest.replace(META_INDEX_FLAG,
getMetaAlertIndex());
PatchRequest patchRequest = JSONUtils.INSTANCE.load(alertPatch,
PatchRequest.class);
metaDao.patch(metaDao, patchRequest,
Optional.of(System.currentTimeMillis()));
- Assert.fail("A patch on the alert field should throw an exception");
+ fail("A patch on the alert field should throw an exception");
Review comment:
Might be worth using the new idiom for exception testing here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
