[
https://issues.apache.org/jira/browse/METRON-720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871358#comment-15871358
]
ASF GitHub Bot commented on METRON-720:
---------------------------------------
Github user mattf-horton commented on the issue:
https://github.com/apache/incubator-metron/pull/455
@JonZeolla , thanks for the suggestions. Incorporated the SIG traps and
better exit codes, as well as improvements to the 'find -exec' error catching
logic. Also added 'set -e' and trap on ERR, and fixed an exit code in the
fix-md-dialect.py script.
Changes related to $() vs ``, and explicit declaration of array variables
that are being initialized on first use, are valid alternative syntax, but my
usages are equivalent. I consider the variants I used to be less cluttered, so
I kept them.
While I was at it, I also fixed METRON-717, splitting site.xml into a
tracked template file and an untracked auto-generated portion, in git.
> modify generate-md.sh to re-throw errors from within 'find'
> -----------------------------------------------------------
>
> Key: METRON-720
> URL: https://issues.apache.org/jira/browse/METRON-720
> Project: Metron
> Issue Type: Bug
> Affects Versions: 0.3.1
> Reporter: Matt Foley
>
> In the site-book build tools, bin/generate-md.sh invokes
> bin/fix-md-dialect.py from within a `find -exec` context. If
> fix-md-dialect.py encounters errors, it outputs error messages on stderr, but
> these messages may get lost in the rest of the output, and the exit status of
> the script just indicates success.
> Modify the invocation of `find` to capture the error condition, complain
> about it in a way that does not get lost amongst the other output, and cause
> bin/generate-md.sh to exit with a failure condition.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
