[
https://issues.apache.org/jira/browse/METRON-720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872296#comment-15872296
]
ASF GitHub Bot commented on METRON-720:
---------------------------------------
Github user mattf-horton commented on the issue:
https://github.com/apache/incubator-metron/pull/455
Hi @JonZeolla , thanks for taking a look amidst the other demands on your
time.
I disagree with 'mv $fullpath/site.xml.bak $fullpath/site.xml' for the
following reasons:
* site.xml is now a fully auto-generated file (like the contents of
site/markdown/), and is no longer tracked in git. That was the METRON-717
improvement. Thus, there is no reason to restore it.
* There are many other artifacts of bin/generate-md.sh besides site.xml,
that cannot be restored to former state, and that are likely to be just as
broken as site.xml if the build is interrupted. I don't want to give the
impression that we've restored a valid overall context.
* Leaving the entire state of the auto-generated content after an
interrupted build, including site.xml, may give valuable information about the
root cause of the break.
Please accept my not incorporating this change :-)
BTW, for Jon and all reviewers, I should mention that after this patch I
did a full re-validation of the site-book, both by:
* visual inspection in a browser of every page of the resulting book, and
by
* recursive diff of both the generated MD source files and resulting HTML
book files, before and after this whole PR patch.
No unexpected differences were found. Thanks.
> modify generate-md.sh to re-throw errors from within 'find'
> -----------------------------------------------------------
>
> Key: METRON-720
> URL: https://issues.apache.org/jira/browse/METRON-720
> Project: Metron
> Issue Type: Bug
> Affects Versions: 0.3.1
> Reporter: Matt Foley
>
> In the site-book build tools, bin/generate-md.sh invokes
> bin/fix-md-dialect.py from within a `find -exec` context. If
> fix-md-dialect.py encounters errors, it outputs error messages on stderr, but
> these messages may get lost in the rest of the output, and the exit status of
> the script just indicates success.
> Modify the invocation of `find` to capture the error condition, complain
> about it in a way that does not get lost amongst the other output, and cause
> bin/generate-md.sh to exit with a failure condition.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
