[
https://issues.apache.org/jira/browse/METRON-720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871708#comment-15871708
]
ASF GitHub Bot commented on METRON-720:
---------------------------------------
Github user JonZeolla commented on the issue:
https://github.com/apache/incubator-metron/pull/455
Sounds good to me. I typically use declare for all variables just to be
explicit and obvious with my intent, and use $() as a standard for readability
and easy nesting as opposed to \`\`. That said, as you mentioned, they are
definitely equivalent to what you have across the board.
I did a quick review on my phone, but there are enough changes it probably
merits a run up and validation on a screen larger than 5". That said, I would
consider adding something like:
```
If [ -e $fullpath/site.xml.bak ]; then
mv $fullpath/site.xml.bak $fullpath/site.xml
fi
```
To the quit function to reinstate the prior site.xml (replacing `$fullpath`
appropriately). I'll try to spin this up today if I can because I'm gone all
next week without access to the real world (i.e. Internet).
> modify generate-md.sh to re-throw errors from within 'find'
> -----------------------------------------------------------
>
> Key: METRON-720
> URL: https://issues.apache.org/jira/browse/METRON-720
> Project: Metron
> Issue Type: Bug
> Affects Versions: 0.3.1
> Reporter: Matt Foley
>
> In the site-book build tools, bin/generate-md.sh invokes
> bin/fix-md-dialect.py from within a `find -exec` context. If
> fix-md-dialect.py encounters errors, it outputs error messages on stderr, but
> these messages may get lost in the rest of the output, and the exit status of
> the script just indicates success.
> Modify the invocation of `find` to capture the error condition, complain
> about it in a way that does not get lost amongst the other output, and cause
> bin/generate-md.sh to exit with a failure condition.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
