[
https://issues.apache.org/jira/browse/METRON-720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872404#comment-15872404
]
ASF GitHub Bot commented on METRON-720:
---------------------------------------
Github user JonZeolla commented on the issue:
https://github.com/apache/incubator-metron/pull/455
I'm a -1 (non-binding) on this for now, primarily because the bash fails to
run on CentOS 6.8 (where I tested it). The error was `basename: invalid option
-- 's'`.
I think I able to fix the issue by changing that line to
`item_name=$(basename ${md%.*})` (feel free to sub backticks, just hard to show
in GitHub md)
Regarding the prior discussions
I guess I fail to see the reason why site.xml.bak is created in the first
place then. A reasonable alternative in my mind would be to add something like
`diff $fullpath/site.xml $fullpath/site.xml.bak && rm $fullpath/site.xml.bak`
to `quit()`.
> modify generate-md.sh to re-throw errors from within 'find'
> -----------------------------------------------------------
>
> Key: METRON-720
> URL: https://issues.apache.org/jira/browse/METRON-720
> Project: Metron
> Issue Type: Bug
> Affects Versions: 0.3.1
> Reporter: Matt Foley
>
> In the site-book build tools, bin/generate-md.sh invokes
> bin/fix-md-dialect.py from within a `find -exec` context. If
> fix-md-dialect.py encounters errors, it outputs error messages on stderr, but
> these messages may get lost in the rest of the output, and the exit status of
> the script just indicates success.
> Modify the invocation of `find` to capture the error condition, complain
> about it in a way that does not get lost amongst the other output, and cause
> bin/generate-md.sh to exit with a failure condition.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
