[
https://issues.apache.org/jira/browse/METRON-720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872934#comment-15872934
]
ASF GitHub Bot commented on METRON-720:
---------------------------------------
Github user JonZeolla commented on the issue:
https://github.com/apache/incubator-metron/pull/455
Spun it up on CentOS 6.8 and macOX 10.12.3, and did a quick code review.
Spot tested the traps as well. +1 (non-binding).
The only thing I noticed is I don't think
[this](https://github.com/mattf-horton/incubator-metron/blob/0.3.1-rc4/site-book/bin/generate-md.sh#L300)
is necessary due to the `>` in the following line.
> modify generate-md.sh to re-throw errors from within 'find'
> -----------------------------------------------------------
>
> Key: METRON-720
> URL: https://issues.apache.org/jira/browse/METRON-720
> Project: Metron
> Issue Type: Bug
> Affects Versions: 0.3.1
> Reporter: Matt Foley
>
> In the site-book build tools, bin/generate-md.sh invokes
> bin/fix-md-dialect.py from within a `find -exec` context. If
> fix-md-dialect.py encounters errors, it outputs error messages on stderr, but
> these messages may get lost in the rest of the output, and the exit status of
> the script just indicates success.
> Modify the invocation of `find` to capture the error condition, complain
> about it in a way that does not get lost amongst the other output, and cause
> bin/generate-md.sh to exit with a failure condition.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
