[
https://issues.apache.org/jira/browse/METRON-720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872510#comment-15872510
]
ASF GitHub Bot commented on METRON-720:
---------------------------------------
Github user mattf-horton commented on the issue:
https://github.com/apache/incubator-metron/pull/455
Hi @JonZeolla , @ottobackwards , @cestella , @mmiklavc ,
Thanks to all of you for looking at this. Taking issues in order:
1. Absolutely right, no reason to have site.xml.bak any more! Missed that,
will fix momentarily.
2. I'll have to look at that basename issue, but will fix and test on
Centos. Glad you noticed, and sorry about that.
3. The weird behavior with site.xml and .gitignore is because the "git rm
site.xml" command and the change to add "site.xml" to .gitignore, were squashed
into a single commit. If you do it as a sequence of two commits then it
transpires cleanly. But I was trying to respect the preference for squashing
commits. It won't manifest in fresh "git clone"s, but is a nuisance for folks
pulling into an existing branch.
Since I have to make another commit to fix #1 and #2, I will also split #3
back into separate commits. Thanks.
> modify generate-md.sh to re-throw errors from within 'find'
> -----------------------------------------------------------
>
> Key: METRON-720
> URL: https://issues.apache.org/jira/browse/METRON-720
> Project: Metron
> Issue Type: Bug
> Affects Versions: 0.3.1
> Reporter: Matt Foley
>
> In the site-book build tools, bin/generate-md.sh invokes
> bin/fix-md-dialect.py from within a `find -exec` context. If
> fix-md-dialect.py encounters errors, it outputs error messages on stderr, but
> these messages may get lost in the rest of the output, and the exit status of
> the script just indicates success.
> Modify the invocation of `find` to capture the error condition, complain
> about it in a way that does not get lost amongst the other output, and cause
> bin/generate-md.sh to exit with a failure condition.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
