[
https://issues.apache.org/jira/browse/NIFI-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376136#comment-15376136
]
ASF GitHub Bot commented on NIFI-2142:
--------------------------------------
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/609#discussion_r70735844
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformXml.java
---
@@ -76,25 +84,59 @@
.name("XSLT file name")
.description("Provides the name (including full path) of the
XSLT file to apply to the flowfile XML content.")
.required(true)
+ .expressionLanguageSupported(true)
.addValidator(StandardValidators.FILE_EXISTS_VALIDATOR)
.build();
+ public static final PropertyDescriptor INDENT_OUTPUT = new
PropertyDescriptor.Builder()
+ .name("indent-output")
+ .displayName("Indent")
+ .description("Whether or not to indent the output.")
+ .required(true)
+ .defaultValue("true")
+ .allowableValues("true", "false")
+ .addValidator(StandardValidators.BOOLEAN_VALIDATOR)
+ .build();
+
+ public static final PropertyDescriptor CACHE_SIZE = new
PropertyDescriptor.Builder()
+ .name("cache-size")
+ .displayName("Cache size")
+ .description("Maximum size of the stylesheet cache.")
+ .required(true)
+ .defaultValue("100")
+
.addValidator(StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR)
--- End diff --
Also, this is a integer validator but the property is interpreted as a long
on line 171
> Cache compiled XSLT in TransformXml
> -----------------------------------
>
> Key: NIFI-2142
> URL: https://issues.apache.org/jira/browse/NIFI-2142
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Joey Frazee
> Fix For: 1.0.0
>
>
> TransformXml appears to be recompiling the XSLT on every onTrigger event,
> which is slow. It should cache the compiled stylesheets.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
