[
https://issues.apache.org/jira/browse/NIFI-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15390238#comment-15390238
]
ASF GitHub Bot commented on NIFI-2142:
--------------------------------------
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/609#discussion_r71950331
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformXml.java
---
@@ -76,25 +84,59 @@
.name("XSLT file name")
.description("Provides the name (including full path) of the
XSLT file to apply to the flowfile XML content.")
.required(true)
+ .expressionLanguageSupported(true)
.addValidator(StandardValidators.FILE_EXISTS_VALIDATOR)
.build();
+ public static final PropertyDescriptor INDENT_OUTPUT = new
PropertyDescriptor.Builder()
+ .name("indent-output")
+ .displayName("Indent")
+ .description("Whether or not to indent the output.")
+ .required(true)
+ .defaultValue("true")
+ .allowableValues("true", "false")
+ .addValidator(StandardValidators.BOOLEAN_VALIDATOR)
+ .build();
+
+ public static final PropertyDescriptor CACHE_SIZE = new
PropertyDescriptor.Builder()
+ .name("cache-size")
+ .displayName("Cache size")
+ .description("Maximum size of the stylesheet cache.")
+ .required(true)
+ .defaultValue("100")
+
.addValidator(StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR)
+ .build();
+
+ public static final PropertyDescriptor CACHE_DURATION = new
PropertyDescriptor.Builder()
+ .name("cache-duration")
+ .displayName("Cache duration")
+ .description("How long to keep stylesheets in the cache.")
--- End diff --
@JPercivall It can be either. Do you have thoughts on which is preferable.
If kept as is, how does "How long to keep stylesheets in the cache after last
time of access" sound?
> Cache compiled XSLT in TransformXml
> -----------------------------------
>
> Key: NIFI-2142
> URL: https://issues.apache.org/jira/browse/NIFI-2142
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Joey Frazee
> Fix For: 1.0.0
>
>
> TransformXml appears to be recompiling the XSLT on every onTrigger event,
> which is slow. It should cache the compiled stylesheets.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
