adamdebreceni commented on a change in pull request #857:
URL: https://github.com/apache/nifi-minifi-cpp/pull/857#discussion_r480886774
##########
File path: libminifi/src/core/ProcessSession.cpp
##########
@@ -939,9 +939,7 @@ void ProcessSession::persistFlowFilesBeforeTransfer(
if (ff->isStored() && flowFileRepo->Delete(ff->getUUIDStr())) {
// original must be non-null since this flowFile is already stored
in the repos ->
// must have come from a session->get()
- auto claim = original->getResourceClaim();
- // decrement on behalf of the persisted-instance-to-be-deleted
- if (claim) claim->decreaseFlowFileRecordOwnedCount();
Review comment:
since `flowFileRepo->Delete` is async, the deletion from the content
repository has to be the responsibility of the FlowFileRepository (as was
before only with `removeIfOrphaned`), but as we would like to handle the
removal of content automatically based on the refCount, that method has been
removed, so now a `decreaseFlowFileRecordOwnedCount` will trigger a remove if
the refCount goes to zero
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
