szaszm commented on a change in pull request #857:
URL: https://github.com/apache/nifi-minifi-cpp/pull/857#discussion_r481044401
##########
File path: libminifi/include/ResourceClaim.h
##########
@@ -104,9 +96,8 @@ class ResourceClaim : public
std::enable_shared_from_this<ResourceClaim> {
}
protected:
- std::atomic<bool> deleted_;
// Full path to the content
- std::string _contentFullPath;
+ const Path _contentFullPath;
Review comment:
I'm not sure `const` is a good idea here. It disables copy/move
assignment, but not construction.
More details: https://abseil.io/tips/177
I tend to generalize these guidelines to "generally avoid `const` or
reference non-static data members".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
