adamdebreceni commented on a change in pull request #857:
URL: https://github.com/apache/nifi-minifi-cpp/pull/857#discussion_r480899565
##########
File path: libminifi/include/ResourceClaim.h
##########
@@ -45,8 +45,10 @@ extern std::string default_directory_path;
extern void setDefaultDirectory(std::string);
// ResourceClaim Class
-class ResourceClaim : public std::enable_shared_from_this<ResourceClaim> {
+class ResourceClaim {
public:
+ // the type which uniquely represents the resource for the owning manager
+ using Path = std::string;
Review comment:
changed the ctor
changing ResourceClaim into a class template incurs quite the change in the
codebase, I didn't intend to make ResourceClaim generic, but to separate out
the implementation of the "Path", so we could later maybe use Identifier or
other stuff, but it's doable to make it generic, would you like me to do it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
