adamdebreceni commented on a change in pull request #857:
URL: https://github.com/apache/nifi-minifi-cpp/pull/857#discussion_r481060518
##########
File path: libminifi/src/ResourceClaim.cpp
##########
@@ -41,22 +41,28 @@ void setDefaultDirectory(std::string path) {
}
ResourceClaim::ResourceClaim(std::shared_ptr<core::StreamManager<ResourceClaim>>
claim_manager)
- : claim_manager_(claim_manager),
- deleted_(false),
- logger_(logging::LoggerFactory<ResourceClaim>::getLogger()) {
- auto contentDirectory = claim_manager_->getStoragePath();
- if (contentDirectory.empty())
- contentDirectory = default_directory_path;
+ : claim_manager_(std::move(claim_manager)),
+ logger_(logging::LoggerFactory<ResourceClaim>::getLogger()),
+ _contentFullPath(([&] {
+ auto contentDirectory = claim_manager->getStoragePath();
Review comment:
actually the initializers are executed in the order of their
declaration, and here they are out of sync with the initializer list's order,
will change the order to represent the declaration order
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
