lucasmoten commented on a change in pull request #4576:
URL: https://github.com/apache/nifi/pull/4576#discussion_r510346462
##########
File path:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/FetchS3Object.java
##########
@@ -147,6 +171,11 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
request = new GetObjectRequest(bucket, key, versionId);
}
request.setRequesterPays(requesterPays);
+ if(rangeLength != null) {
Review comment:
I'm trying to test from your recent changes on the branch and ran into
an issue when I set these property values for FetchS3Object
- Range Start = 1
- Range Length = 1
The processor can't validate with that setting as it produces this
validation warning:
- 's3-object-range-start' validated against '1' is invalid because Must be
of format <Data Size> <Data Unit> where <Data Size> is a non-negative integer
and <Data Unit> is a supported Data Unit, such as: B, KB, MB, GB, TB
- Same validation error for 's3-object-range-length'.
To clarify my original concern, should require Range Length be > 0 if Range
Start is set to a value.
Since range requests start at 0 byte, It should be valid to have
- Range Start = 0
- Range Length = 1
with a result indicating that this is requesting just the first byte from
the resource.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
