pkelly-nifi commented on a change in pull request #4576:
URL: https://github.com/apache/nifi/pull/4576#discussion_r510888130
##########
File path:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/FetchS3Object.java
##########
@@ -147,6 +171,11 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
request = new GetObjectRequest(bucket, key, versionId);
}
request.setRequesterPays(requesterPays);
+ if(rangeLength != null) {
Review comment:
I just committed changes with the -1 for the range length calculation
and changed the validators to require a length of at least 1B if it is
specified. I don't think range length should be required when range start is
specified because sometimes we have a need to read to the end of the file from
a starting offset, and reading to the end is the default behavior if range
length is not specified. Please let me know your thoughts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
