pkelly-nifi commented on a change in pull request #4576:
URL: https://github.com/apache/nifi/pull/4576#discussion_r510465823
##########
File path:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/FetchS3Object.java
##########
@@ -147,6 +171,11 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
request = new GetObjectRequest(bucket, key, versionId);
}
request.setRequesterPays(requesterPays);
+ if(rangeLength != null) {
Review comment:
Thanks for your feedback. I just tested it again against real AWS S3
and you are absolutely right. This is apparently a bug in a third party
product we've been using. I will update with the -1 tomorrow.
As for the validation errors you mentioned, this is using DataSize
validation rather than pure long values, which allows shortcuts such as Range
start: 0B, Range Length: 1GB, followed by Range start: 1GB, Range length: 1GB.
So to use plain bytes, it requires adding a 'B' to the end. It seemed slightly
cleaner than requiring someone to calculate out to the exact byte. Do you have
a strong opinion against this syntax? Or a suggestion for making it clearer in
the documentation? I'd be happy to update it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
