lucasmoten commented on a change in pull request #4576:
URL: https://github.com/apache/nifi/pull/4576#discussion_r510900163



##########
File path: 
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/FetchS3Object.java
##########
@@ -147,6 +171,11 @@ public void onTrigger(final ProcessContext context, final 
ProcessSession session
             request = new GetObjectRequest(bucket, key, versionId);
         }
         request.setRequesterPays(requesterPays);
+        if(rangeLength != null) {

Review comment:
       Personally I'm ok with using 0B, though I'd defer to others when it 
comes to standards for that.  If its kept that way, I agree, it should have 
documentation guidance improved.  I plan to take a look at this in the next 24 
hours and will report back.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to