fgerlits commented on a change in pull request #964:
URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r555266906
##########
File path: libminifi/include/utils/StringUtils.h
##########
@@ -159,9 +160,9 @@ class StringUtils {
}
inline static std::string hex_ascii(const std::string& in) {
- int len = in.length();
+ size_t len = in.length();
Review comment:
I have inlined the variable, and added a `reserve` (though I don't think
this will increase performance by a measurable amount).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
