fgerlits commented on a change in pull request #964:
URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551971025
##########
File path: libminifi/test/unit/ZlibStreamTests.cpp
##########
@@ -97,7 +106,8 @@ TEST_CASE("gzip compression and decompression pipeline",
"[basic]") {
for (size_t i = 0U; i < 1024U; i++) {
std::generate(buf.begin(), buf.end(), [&](){return dist(gen);});
original += std::string(reinterpret_cast<const char*>(buf.data()),
buf.size());
- REQUIRE(buf.size() == compressStream.write(buf.data(), buf.size()));
+ int buffer_size = gsl::narrow<int>(buf.size());
+ REQUIRE(buffer_size == compressStream.write(buf.data(),
gsl::narrow<int>(buffer_size)));
Review comment:
I've removed it
##########
File path: main/AgentDocs.cpp
##########
@@ -47,7 +47,7 @@ std::string AgentDocs::extractClassName(const std::string
&processor) const {
auto lastOfIdx = processor.find_last_of(".");
if (lastOfIdx != std::string::npos) {
lastOfIdx++; // if a value is found, increment to move beyond the .
- int nameLength = processor.length() - lastOfIdx;
+ size_t nameLength = processor.length() - lastOfIdx;
std::string processorName = processor.substr(lastOfIdx, nameLength);
Review comment:
fixed
##########
File path: nanofi/tests/CTestsBase.h
##########
@@ -138,7 +138,8 @@ class TestControllerWithTemporaryWorkingDirectory {
}
~TestControllerWithTemporaryWorkingDirectory() {
- chdir(old_cwd_);
+ int success = chdir(old_cwd_);
+ (void) success;
Review comment:
yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
