szaszm commented on a change in pull request #964:
URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r546768707
##########
File path: extensions/rocksdb-repos/DatabaseContentRepository.cpp
##########
@@ -94,7 +97,7 @@ void DatabaseContentRepository::Session::commit() {
if (outStream == nullptr) {
throw Exception(REPOSITORY_EXCEPTION, "Couldn't open the underlying
resource for append: " + resource.first->getContentFullPath());
}
- const auto size = resource.second->size();
+ const int size = gsl::narrow<int>(resource.second->size());
Review comment:
I would narrow it at the last possible moment, as part of the condition
in this case. This is to simplify future changes that make narrowing different
or redundant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
