fgerlits commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r552052405
########## File path: nanofi/include/sitetosite/CPeer.h ########## @@ -88,7 +88,7 @@ static void setPort(struct SiteToSiteCPeer * peer, uint16_t port) { peer->_port = port; if(peer->_url != NULL) { int i; - for(i = strlen(peer->_url) -1; i >= 0; --i) { // look for the last ':' in the string + for(i = (int)(strlen(peer->_url)) - 1; i >= 0; --i) { // look for the last ':' in the string Review comment: This is nanofi code, which is supposed to be in C. This is not entirely true, as there is some C++ code in it already, but I did not want to add more. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org