martinzink commented on a change in pull request #1069:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1069#discussion_r629293827
##########
File path: CMakeLists.txt
##########
@@ -847,21 +847,17 @@ else()
include(DockerConfig)
endif()
-if(NOT WIN32)
# Create a custom build target that will run the linter.
get_property(extensions GLOBAL PROPERTY EXTENSION-LINTERS)
add_custom_target(linter
- COMMAND ${CMAKE_SOURCE_DIR}/thirdparty/google-styleguide/run_linter.sh
- ${CMAKE_SOURCE_DIR}/libminifi/include/ --
- ${CMAKE_SOURCE_DIR}/libminifi/src/
- COMMAND ${CMAKE_SOURCE_DIR}/thirdparty/google-styleguide/run_linter.sh
- ${CMAKE_SOURCE_DIR}/libminifi/include/ --
- ${CMAKE_SOURCE_DIR}/libminifi/test/
- COMMAND ${CMAKE_SOURCE_DIR}/thirdparty/google-styleguide/run_linter.sh
- ${CMAKE_SOURCE_DIR}/encrypt-config/ --
- ${CMAKE_SOURCE_DIR}/encrypt-config/
+ COMMAND python
${CMAKE_SOURCE_DIR}/thirdparty/google-styleguide/run_linter.py -i
Review comment:
Since the run_linter.py only checked the cpp files in the first argument
and only the h files in the second, we didnt check any h files in the
libminifi/test folder.
It also needlesly double checked the libminifi/include folder.
The cpplint.py doesnt require the filelist to be separated by header/source,
so its easier to just have one argument for source and header files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
