martinzink commented on a change in pull request #1069:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1069#discussion_r633506656
##########
File path: libminifi/test/KamikazeProcessor.h
##########
@@ -33,14 +35,14 @@ namespace minifi {
namespace processors {
// GenerateFlowFile Class
class KamikazeProcessor : public core::Processor {
-public:
+ public:
static const std::string OnScheduleExceptionStr;
static const std::string OnTriggerExceptionStr;
static const std::string OnScheduleLogStr;
static const std::string OnTriggerLogStr;
static const std::string OnUnScheduleLogStr;
- KamikazeProcessor(const std::string& name, const utils::Identifier& uuid =
{})
+ explicit KamikazeProcessor(const std::string& name, const utils::Identifier
uuid = utils::Identifier())
Review comment:
not sure, wasnt intentional, reverted to ref
[623b6b1](https://github.com/martinzink/nifi-minifi-cpp/commit/623b6b1c7e21cf9843710ab0e687fd98df7f9e6b)
##########
File path: .github/workflows/ci.yml
##########
@@ -268,8 +306,12 @@ jobs:
sudo ln -s /usr/lib/x86_64-linux-gnu/odbc/libsqlite3odbc.so
/usr/lib/x86_64-linux-gnu/libsqlite3odbc.so
echo "PATH=/usr/lib/ccache:$PATH" >> $GITHUB_ENV
echo -e "127.0.0.1\t$HOSTNAME" | sudo tee -a /etc/hosts > /dev/null
- - id: build
- run: sudo mount tmpfs -t tmpfs /tmp && ./bootstrap.sh -e -t && cd
build && cmake -DUSE_SHARED_LIBS= -DENABLE_OPENWSMAN=ON -DENABLE_OPENCV=ON
-DENABLE_MQTT=ON -DENABLE_GPS=ON -DENABLE_USB_CAMERA=ON -DENABLE_LIBRDKAFKA=ON
-DENABLE_OPC=ON -DENABLE_SFTP=ON -DENABLE_MQTT=ON -DENABLE_COAP=ON
-DENABLE_PYTHON=ON -DENABLE_SQL=ON -DENABLE_AWS=ON -DENABLE_AZURE=ON
-DSTRICT_GSL_CHECKS=AUDIT -DFAIL_ON_WARNINGS=ON .. && cmake --build .
--parallel 4 && make test ARGS="--timeout 300 -j8 --output-on-failure"
+ - name: build
+ run: sudo mount tmpfs -t tmpfs /tmp && ./bootstrap.sh -e -t && cd
build && cmake -DUSE_SHARED_LIBS= -DENABLE_OPENWSMAN=ON -DENABLE_OPENCV=ON
-DENABLE_MQTT=ON -DENABLE_GPS=ON -DENABLE_USB_CAMERA=ON -DENABLE_LIBRDKAFKA=ON
-DENABLE_OPC=ON -DENABLE_SFTP=ON -DENABLE_MQTT=ON -DENABLE_COAP=ON
-DENABLE_PYTHON=ON -DENABLE_SQL=ON -DENABLE_AWS=ON -DENABLE_AZURE=ON
-DSTRICT_GSL_CHECKS=AUDIT -DFAIL_ON_WARNINGS=ON .. && cmake --build .
--parallel 4
+ - name: test
+ run: cd build && make test ARGS="--timeout 300 -j8 --output-on-failure"
+ - name: linter
Review comment:
good point, reduced to one per platform in
[e2a4e48](https://github.com/martinzink/nifi-minifi-cpp/commit/e2a4e487ce85305894d3ba7fc668f5d4f73a9821)
##########
File path: CONTRIB.md
##########
@@ -33,8 +33,15 @@ Apache NiFi MiNiFi C++ is a review then commit community. As
a result, we will r
review. We ask that you provide tests and documentation when possible.
Once you have completed your changes, including source code and tests, you can
verify that you follow the Google style guide by running the following command:
- $ make linter.
-
+##### Linux or macOS
+```
+$ make linter
+```
+##### Windows
+```
+$ msbuild linter.vcxproj
Review comment:
changed it in
[e2a4e48](https://github.com/martinzink/nifi-minifi-cpp/commit/e2a4e487ce85305894d3ba7fc668f5d4f73a9821)
##########
File path: thirdparty/google-styleguide/run_linter.py
##########
@@ -0,0 +1,27 @@
+import argparse
+import os
+import cpplint
+
+script_dir = os.path.dirname(os.path.realpath(__file__))
+parser = argparse.ArgumentParser()
+
+parser.add_argument('-i', '--includePathes', nargs="+", help='Run linter check
in these directories')
Review comment:
changed it in
[e2a4e48](https://github.com/martinzink/nifi-minifi-cpp/commit/e2a4e487ce85305894d3ba7fc668f5d4f73a9821)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
