fgerlits commented on a change in pull request #1069:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1069#discussion_r633631260
##########
File path: CONTRIB.md
##########
@@ -33,8 +33,15 @@ Apache NiFi MiNiFi C++ is a review then commit community. As
a result, we will r
review. We ask that you provide tests and documentation when possible.
Once you have completed your changes, including source code and tests, you can
verify that you follow the Google style guide by running the following command:
- $ make linter.
-
+##### Linux or macOS
+```
+$ make linter
+```
+##### Windows
+```
+$ msbuild linter.vcxproj
Review comment:
nitpicking, but this prompt should be `> `
##########
File path: thirdparty/google-styleguide/run_linter.py
##########
@@ -0,0 +1,27 @@
+import argparse
+import os
+import cpplint
+
+script_dir = os.path.dirname(os.path.realpath(__file__))
+parser = argparse.ArgumentParser()
+
+parser.add_argument('-i', '--includePathes', nargs="+", help='Run linter check
in these directories')
Review comment:
typo: includePathes -> includePaths
##########
File path: .github/workflows/ci.yml
##########
@@ -268,8 +306,12 @@ jobs:
sudo ln -s /usr/lib/x86_64-linux-gnu/odbc/libsqlite3odbc.so
/usr/lib/x86_64-linux-gnu/libsqlite3odbc.so
echo "PATH=/usr/lib/ccache:$PATH" >> $GITHUB_ENV
echo -e "127.0.0.1\t$HOSTNAME" | sudo tee -a /etc/hosts > /dev/null
- - id: build
- run: sudo mount tmpfs -t tmpfs /tmp && ./bootstrap.sh -e -t && cd
build && cmake -DUSE_SHARED_LIBS= -DENABLE_OPENWSMAN=ON -DENABLE_OPENCV=ON
-DENABLE_MQTT=ON -DENABLE_GPS=ON -DENABLE_USB_CAMERA=ON -DENABLE_LIBRDKAFKA=ON
-DENABLE_OPC=ON -DENABLE_SFTP=ON -DENABLE_MQTT=ON -DENABLE_COAP=ON
-DENABLE_PYTHON=ON -DENABLE_SQL=ON -DENABLE_AWS=ON -DENABLE_AZURE=ON
-DSTRICT_GSL_CHECKS=AUDIT -DFAIL_ON_WARNINGS=ON .. && cmake --build .
--parallel 4 && make test ARGS="--timeout 300 -j8 --output-on-failure"
+ - name: build
+ run: sudo mount tmpfs -t tmpfs /tmp && ./bootstrap.sh -e -t && cd
build && cmake -DUSE_SHARED_LIBS= -DENABLE_OPENWSMAN=ON -DENABLE_OPENCV=ON
-DENABLE_MQTT=ON -DENABLE_GPS=ON -DENABLE_USB_CAMERA=ON -DENABLE_LIBRDKAFKA=ON
-DENABLE_OPC=ON -DENABLE_SFTP=ON -DENABLE_MQTT=ON -DENABLE_COAP=ON
-DENABLE_PYTHON=ON -DENABLE_SQL=ON -DENABLE_AWS=ON -DENABLE_AZURE=ON
-DSTRICT_GSL_CHECKS=AUDIT -DFAIL_ON_WARNINGS=ON .. && cmake --build .
--parallel 4
+ - name: test
+ run: cd build && make test ARGS="--timeout 300 -j8 --output-on-failure"
+ - name: linter
Review comment:
Is it useful to run the linter 9 times? I think one on Windows, one on
Linux and one on MacOS would be enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
