szaszm commented on a change in pull request #1191:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1191#discussion_r722107017
##########
File path:
extensions/openwsman/processors/SourceInitiatedSubscriptionListener.cpp
##########
@@ -435,7 +435,6 @@ bool
SourceInitiatedSubscriptionListener::Handler::handleSubscriptionManager(str
ws_xml_set_ns(subscription, XML_NS_CUSTOM_SUBSCRIPTION, "m");
// Body/EnumerationResponse/Items/Subscription/Version
- std::lock_guard<std::mutex> lock(processor_.mutex_);
Review comment:
This is in an http request handler. Are you certain that civetweb (http
server) doesn't use multiple threads that need synchronization on concurrent
incoming requests? I don't know its internals, but I think this might be an
issue if it does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
