szaszm commented on a change in pull request #1191:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1191#discussion_r722279658
##########
File path:
extensions/openwsman/processors/SourceInitiatedSubscriptionListener.cpp
##########
@@ -435,7 +435,6 @@ bool
SourceInitiatedSubscriptionListener::Handler::handleSubscriptionManager(str
ws_xml_set_ns(subscription, XML_NS_CUSTOM_SUBSCRIPTION, "m");
// Body/EnumerationResponse/Items/Subscription/Version
- std::lock_guard<std::mutex> lock(processor_.mutex_);
Review comment:
My theory is that civetweb calls the handler on a thread that is not in
our normal thread pool. This means if the processor is running and an http
requests are handled at the same time, or multiple http requests are being
handled (on civet threads), then `subscribers_` is accessed concurrently, which
is a data race.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
