adamdebreceni commented on a change in pull request #1191:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1191#discussion_r723191038
##########
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##########
@@ -188,7 +188,6 @@ ConsumeWindowsEventLog::ConsumeWindowsEventLog(const
std::string& name, const ut
}
void ConsumeWindowsEventLog::notifyStop() {
- std::lock_guard<std::mutex> lock(on_trigger_mutex_);
logger_->log_trace("start notifyStop");
bookmark_.reset();
Review comment:
could an `onTrigger` be running when this `notifyStop` is called? if it
could, the mutex protects the bookmark so we might not be able to remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
