adam-markovics commented on a change in pull request #1191:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1191#discussion_r722252824
##########
File path:
extensions/openwsman/processors/SourceInitiatedSubscriptionListener.cpp
##########
@@ -435,7 +435,6 @@ bool
SourceInitiatedSubscriptionListener::Handler::handleSubscriptionManager(str
ws_xml_set_ns(subscription, XML_NS_CUSTOM_SUBSCRIPTION, "m");
// Body/EnumerationResponse/Items/Subscription/Version
- std::lock_guard<std::mutex> lock(processor_.mutex_);
Review comment:
It seems to me that the mutex was there because of the member
`subscribers_`, and is not related to civetweb. But because I can't tell for
sure, and because this processor is unused (AFAIK) I will put it back, it won't
do harm. From commit history it seems like nobodoy else touched the processor
seriously other than the initial commit from bakaid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
