ottobackwards commented on a change in pull request #5475:
URL: https://github.com/apache/nifi/pull/5475#discussion_r735697470



##########
File path: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##########
@@ -1269,4 +1291,17 @@ private Charset getCharsetFromMediaType(MediaType 
contentType) {
     private static File getETagCacheDir() throws IOException {
         return 
Files.createTempDirectory(InvokeHTTP.class.getSimpleName()).toFile();
     }
+
+    private String getFileNameFromUrl(URL url) {
+        String fileName;
+        String path = StringUtils.removeEnd(url.getPath(), "/");
+

Review comment:
       the URL is a class with functions for handling the URL parts correctly, 
you should need to use manual parsing here.
   
   We have commons.io already as a dependency,  so you should be able to 
   
   ```
   import org.apache.commons.io.FilenameUtils;
   
   FilenameUtils.getName(url.getPath());
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to