lordgamez commented on a change in pull request #1216:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1216#discussion_r758145801
##########
File path: docker/test/integration/minifi/core/FileSystemObserver.py
##########
@@ -31,21 +31,26 @@ def restart_observer_if_needed(self):
self.observer.schedule(self.event_handler, self.test_output_dir,
recursive=True)
self.observer.start()
- def wait_for_output(self, timeout_seconds, max_files):
+ def wait_for_output(self, timeout_seconds, max_files, output_validator):
Review comment:
That's true, unfortunately I could not find a better solution to return
early if we have the required match. Our use case is that in the matchers where
we need "at least" N number of matches we can stop the test when that happens
without knowing how many files should we wait for. For that we need the
validator and the file observer to have an interaction. Do you have any other
suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
