lordgamez commented on a change in pull request #1216:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1216#discussion_r758310378
##########
File path: extensions/opc/src/opcbase.cpp
##########
@@ -84,45 +83,41 @@ namespace processors {
auto certificatePathRes = context->getProperty(CertificatePath.getName(),
certpath_);
auto keyPathRes = context->getProperty(KeyPath.getName(), keypath_);
- auto trustedPathRes = context->getProperty(TrustedPath.getName(),
trustpath_);
- if (certificatePathRes != keyPathRes || keyPathRes != trustedPathRes) {
- throw Exception(PROCESS_SCHEDULE_EXCEPTION, "All or none of Certificate
path, Key path and Trusted server certificate path should be provided!");
+ context->getProperty(TrustedPath.getName(), trustpath_);
+ if (certificatePathRes != keyPathRes) {
+ throw Exception(PROCESS_SCHEDULE_EXCEPTION, "All or none of Certificate
path and Key path should be provided!");
}
- if (!password_.empty() && (certpath_.empty() || keypath_.empty() ||
trustpath_.empty() || applicationURI_.empty())) {
- throw Exception(PROCESS_SCHEDULE_EXCEPTION, "Certificate path, Key path,
Trusted server certificate path and Application URI must be provided in case
Password is provided!");
Review comment:
Updated in 475b5b9e610e56601a07079cb354749ab9790f42
##########
File path: docker/test/integration/steps/steps.py
##########
@@ -63,19 +63,31 @@ def step_impl(context, processor_type, property,
property_value, processor_name)
format(processor_type=processor_type,
property=property, property_value=property_value,
minifi_container_name="minifi-cpp-flow", processor_name=processor_name))
-@given("a {processor_type} processor in the \"{minifi_container_name}\" flow")
-@given("a {processor_type} processor in a \"{minifi_container_name}\" flow")
-@given("a {processor_type} processor set up in a \"{minifi_container_name}\"
flow")
-def step_impl(context, processor_type, minifi_container_name):
+@given("a {processor_type} processor with the name \"{processor_name}\" in the
\"{minifi_container_name}\" flow")
+def step_impl(context, processor_type, processor_name, minifi_container_name):
container = context.test.acquire_container(minifi_container_name)
processor = locate("minifi.processors." + processor_type + "." +
processor_type)()
- processor.set_name(processor_type)
+ processor.set_name(processor_name)
context.test.add_node(processor)
# Assume that the first node declared is primary unless specified otherwise
if not container.get_start_nodes():
container.add_start_node(processor)
+@given("a {processor_type} processor with the name \"{processor_name}\"")
+def step_impl(context, processor_type, processor_name):
+ context.execute_steps("given a {processor_type} processor with the name
\"{processor_name}\" in the \"{minifi_container_name}\" flow".
+ format(processor_type=processor_type,
minifi_container_name="minifi-cpp-flow", processor_name=processor_name))
Review comment:
Updated in 475b5b9e610e56601a07079cb354749ab9790f42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
