fgerlits commented on a change in pull request #1216:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1216#discussion_r760859351



##########
File path: docker/test/integration/MiNiFi_integration_test_driver.py
##########
@@ -141,7 +141,7 @@ def check_for_multiple_files_generated(self, file_count, 
timeout_seconds, expect
     def check_for_at_least_one_file_with_content_generated(self, content, 
timeout_seconds):
         output_validator = 
SingleOrMultiFileOutputValidator(decode_escaped_str(content))
         
output_validator.set_output_dir(self.file_system_observer.get_output_dir())
-        self.check_output(timeout_seconds, output_validator, 1)
+        self.check_output(timeout_seconds, output_validator, timeout_seconds)

Review comment:
       I see.  It would be better to make this clearer in the code, as 
currently it looks "wrong".  Something like this?
   ```suggestion
           expected_number_of_files = timeout_seconds
           self.check_output(timeout_seconds, output_validator, 
expected_number_of_files)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to