lordgamez commented on a change in pull request #1216:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1216#discussion_r758311402
##########
File path: docker/test/integration/minifi/core/MinifiContainer.py
##########
@@ -8,8 +8,10 @@ class MinifiContainer(FlowContainer):
MINIFI_VERSION = os.environ['MINIFI_VERSION']
MINIFI_ROOT = '/opt/minifi/nifi-minifi-cpp-' + MINIFI_VERSION
- def __init__(self, config_dir, name, vols, network, image_store):
- super().__init__(config_dir, name, 'minifi-cpp', vols, network,
image_store)
+ def __init__(self, config_dir, name, vols, network, image_store,
command=None):
+ if not command:
+ command = ["/bin/sh", "-c", "cp /tmp/minifi_config/config.yml " +
MinifiContainer.MINIFI_ROOT + "/conf &&
/opt/minifi/minifi-current/bin/minifi.sh run"]
Review comment:
The problem with this that the containers are created through a factory
method where the default value for the command `None` is passed down to this
constructor thus even if this has another default it won't be used, so I stayed
with this version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
