fgerlits commented on a change in pull request #1216:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1216#discussion_r761774335
##########
File path: docker/test/integration/minifi/core/FileSystemObserver.py
##########
@@ -31,21 +31,26 @@ def restart_observer_if_needed(self):
self.observer.schedule(self.event_handler, self.test_output_dir,
recursive=True)
self.observer.start()
- def wait_for_output(self, timeout_seconds, max_files):
+ def wait_for_output(self, timeout_seconds, max_files, output_validator):
Review comment:
I think the problem is that we are trying to do two different things
with the same `check_output` function; this was already so before this PR. I
have created a ticket about this:
https://issues.apache.org/jira/browse/MINIFICPP-1696.
I'm OK with keeping it like this for now, and someone will fix
MINIFICPP-1696 later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
