martinzink commented on a change in pull request #1225:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1225#discussion_r782243096
##########
File path: extensions/mqtt/controllerservice/MQTTControllerService.h
##########
@@ -293,8 +289,8 @@ class MQTTControllerService : public
core::controller::ControllerService {
MQTTClient client_;
std::string uri_;
std::string topic_;
- int64_t keepAliveInterval_;
- int64_t connectionTimeOut_;
+ std::chrono::milliseconds keepAliveInterval_{0};
+ std::chrono::milliseconds connectionTimeOut_{0};
Review comment:
good idea, changed it in
https://github.com/apache/nifi-minifi-cpp/pull/1225/commits/9f0c3752c6a328e005bb22a566eceb406c7fe348
##########
File path: libminifi/test/unit/CpuUsageTest.cpp
##########
@@ -23,39 +23,39 @@
#include "utils/ProcessCpuUsageTracker.h"
#include "../TestBase.h"
-void busySleep(int duration_ms, std::chrono::milliseconds& start_ms,
std::chrono::milliseconds& end_ms, const std::chrono::system_clock::time_point&
origin) {
- start_ms = std::chrono::duration_cast<std::chrono::milliseconds>
(std::chrono::system_clock::now() - origin);
- end_ms = std::chrono::duration_cast<std::chrono::milliseconds>
(std::chrono::system_clock::now() - origin);
- while (end_ms-start_ms < std::chrono::milliseconds(duration_ms)) {
- end_ms = std::chrono::duration_cast<std::chrono::milliseconds>
(std::chrono::system_clock::now() - origin);
+using namespace std::literals::chrono_literals;
+using namespace std::chrono;
Review comment:
fixed it in
https://github.com/apache/nifi-minifi-cpp/pull/1225/commits/9f0c3752c6a328e005bb22a566eceb406c7fe348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
